Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Sep 1, 2025

Part of #2725

Stand (YDB DEV VLA02 has settings, other clusters don't): https://nda.ya.ru/t/azemFeOT7JMYHy

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.38 MB | Main: 85.38 MB
Diff: +2.66 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for meta proxy functionality to automatically route API requests through a cluster-specific proxy endpoint when the use_meta_proxy setting is enabled for a cluster. This allows YDB clusters to be accessed through a unified proxy interface rather than requiring direct balancer connections.

Key changes:

  • Added prepareBackendWithMetaProxy utility function to generate proxy-based backend URLs
  • Modified cluster data preparation to conditionally use meta proxy instead of balancer-based backends
  • Updated API base class to automatically route requests through meta proxy when enabled
  • Enhanced API constructor to pass single cluster mode context to all API instances

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/parseBalancer.ts Added new utility function to generate meta proxy backend URLs
src/store/reducers/clusters/utils.ts Modified cluster preparation logic to conditionally use meta proxy
src/store/configureStore.ts Updated API constructor to include single cluster mode parameter
src/services/api/index.ts Enhanced API class constructors to accept and pass base API parameters
src/services/api/base.ts Added meta proxy path resolution logic and base API parameters interface
src/containers/AppWithClusters/utils/useAdditionalTenantsProps.tsx Added meta proxy support for tenant backend preparation

@artemmufazalov artemmufazalov marked this pull request as ready for review September 1, 2025 10:27
@artemmufazalov artemmufazalov added this pull request to the merge queue Sep 1, 2025
Merged via the queue into main with commit baf5a6f Sep 1, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 2725-allow-meta-proxy branch September 1, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants